Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svp): Bump Savings Plan to ODS 18 - Epic #14733

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat(svp): Bump Savings Plan to ODS 18 - Epic #14733

wants to merge 9 commits into from

Conversation

lionel95200x
Copy link
Contributor

@lionel95200x lionel95200x commented Dec 27, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? yes
Tickets Fix #TAPC-2456
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Update savings plan to ods 18

Related

@lionel95200x lionel95200x requested review from a team as code owners December 27, 2024 13:32
@github-actions github-actions bot added dependencies Pull requests that update a dependency file feature New feature labels Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024 •
edited
Loading

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovh-ux/manager-pci-common UPDATED 0.14.2 1.0.4

@lionel95200x lionel95200x changed the title feat(svp): Bump Savings Plan to ODS 18 feat(svp): Bump Savings Plan to ODS 18 - Epic Dec 27, 2024
Eric-ciccotti
Eric-ciccotti previously approved these changes Jan 6, 2025
View reviewed changes
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from e1d213e to dda0dc0 Compare January 6, 2025 15:50
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 7, 2025
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from dda0dc0 to d254fd0 Compare January 7, 2025 12:55
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 7, 2025
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from d254fd0 to a9c5891 Compare January 7, 2025 14:41
SimonChaumet
SimonChaumet previously approved these changes Jan 7, 2025
View reviewed changes
stif59100
stif59100 previously approved these changes Jan 8, 2025
View reviewed changes
@lionel95200x lionel95200x dismissed stale reviews from stif59100 and SimonChaumet via a2ab5ad January 8, 2025 10:13
Lionel Bueno and others added 5 commits January 8, 2025 11:40
feat: bump ods 18 for savings plan
831ffe2 
Signed-off-by: Lionel Bueno <[email protected]>
@lionel95200x
feat: update component to ods 18 (#14652)
472e633 
ref: TAPC-2456

Signed-off-by: Lionel Bueno <[email protected]>
@Eric-ciccotti
fix: bump ods18 svp fix unit tests (#14734)
c9fb54b 
* fix(pci.savings-plan): fix TU

ref: TAPC-2456
Signed-off-by: Eric Ciccotti <[email protected]>

* fix: remove not used test

Signed-off-by: Lionel Bueno <[email protected]>

* fix: lint bad import

Signed-off-by: Lionel Bueno <[email protected]>

---------

Signed-off-by: Eric Ciccotti <[email protected]>
Signed-off-by: Lionel Bueno <[email protected]>
Co-authored-by: Eric Ciccotti <[email protected]>
Co-authored-by: Lionel Bueno <[email protected]>
@lionel95200x
fix: design issue after bump ods18 (#14741)
0631766 
ref: TAPC-2456

Signed-off-by: Lionel Bueno <[email protected]>
@SimonChaumet
test(svp): use name and href as target instead of testid
b7ec7ae 
Signed-off-by: Simon Chaumet <[email protected]>
fix: unit test
710d347 
Signed-off-by: Lionel Bueno <[email protected]>
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from a2ab5ad to 710d347 Compare January 8, 2025 10:41
Lionel Bueno and others added 2 commits January 9, 2025 11:14
fix: quantity update and bump pci-common
9bd68ca 
Signed-off-by: Lionel Bueno <[email protected]>
@Eric-ciccotti
fix(pci.savings-plan): fix layout and pr return (#14811)
103150d 
ref: TAPC-1454

Signed-off-by: Eric Ciccotti <[email protected]>
Co-authored-by: Eric Ciccotti <[email protected]>
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from 4353f80 to 667d9a4 Compare January 9, 2025 15:55
fix: set quantity to 1 if exceed
f41ea6f 
ref: TAPC-2456

Signed-off-by: Lionel Bueno <[email protected]>
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from 667d9a4 to f41ea6f Compare January 10, 2025 08:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stif59100 stif59100 stif59100 left review comments

@Eric-ciccotti Eric-ciccotti Eric-ciccotti left review comments

@SimonChaumet SimonChaumet SimonChaumet left review comments

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@aottr aottr Awaiting requested review from aottr aottr is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lionel95200x @SimonChaumet @Eric-ciccotti @stif59100